Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add git sha to the build process #2364

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fix: add git sha to the build process #2364

merged 1 commit into from
Oct 19, 2021

Conversation

manekenpix
Copy link
Member

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

After merging #2328, our banner couldn't fetch and display master's current commit. This fixes the building process so the front-end (specifically Telescope's banner) can fetch the required information from the back-end to display the current commit.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix self-assigned this Oct 17, 2021
humphd
humphd reviewed Oct 17, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to find a way to not have to do this. Can we not pass this ref in on an env? I think we discussed this in Slack already.

@manekenpix
Copy link
Member Author

I would love to find a way to not have to do this. Can we not pass this ref in on an env? I think we discussed this in Slack already.

@humphd I forgot about the discussion. I'll work on it

@manekenpix manekenpix changed the title Fix: add copying the git folder into the backend container Fix: add git sha to the build process Oct 18, 2021
@manekenpix manekenpix requested a review from humphd October 18, 2021 01:58
humphd
humphd approved these changes Oct 18, 2021
View reviewed changes
tools/autodeployment/deploy.sh
@@ -31,6 +31,8 @@ else
OLD="green"
fi

echo "GIT_COMMIT=$2" >> $ENV_FILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what do you have to do to get this in here?

Copy link
Member Author

@manekenpix manekenpix Oct 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$2 comes from here (build.githubData.after).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@manekenpix manekenpix merged commit fbb66fe into Seneca-CDOT:master Oct 19, 2021
@manekenpix manekenpix deleted the fix-banner branch October 19, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

Assignees

@manekenpix manekenpix

Labels
area: back-end hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manekenpix @humphd