Fix #2361: Extract unique github urls from each post

[Andrewnt219]

Issue This PR Addresses

Fix #2361

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Add a function to extract all the unique Github links from each post.

Test plan

const htmlString = `
<-- Duplicate links -->
<a href="https://github.com/user/repo/issues/1">Issue 1</a>
<a href="https://github.com/user/repo/issues/1">Issue 1</a>

<a href="https://github.com/user/repo">Repo 1</a>
<a href="https://github.com/user/repo/pull/2">Pull Request 1</a>
`;

extractGitHubUrlsFromPost(htmlString); // ["https://github.com/user/repo/issues/1", "https://github.com/user/repo", "https://github.com/user/repo/pull/2" ]
`

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[manekenpix]

Nice!
I left a few comments, but I think it's almost there 👍

[manekenpix]

👍

[humphd]

This looks good. A few questions:

1. what about splitting these up into repos, issues, prs?
2. should we move this into a hook, const { repos, issues, prs } = useGitHubUrls(post.html)? That way we can manage any changes to the post and post.html and (re)create these.
3. this seems pretty testable. Should we add some?

All of this could happen in follow-up PRs by you or other people, or we could do it here. Let me know how you want to proceed.

[Andrewnt219]

@humphd

1. When I talked to Francesco, he had already been working on the filter function.
2. The filterGithubIssues can call this extractGitHubUrlsFromPost internally. These two functions don't need to hook into React lifecycle, so I don't think making them a hook is necessary.
3. I did look through the test folder for a suitable test setup, but I only found backend test code. Did I look at the wrong place?

As they are all relevant to this function, I can add more commits to this PR.

[humphd]

• When I talked to Francesco, he had already been working on the filter function.

Alright, that's fine.

• The filterGithubIssues can call this extractGitHubUrlsFromPost internally. These two functions don't need to hook into React lifecycle, so I don't think making them a hook is necessary.

OK

• I did look through the test folder for a suitable test setup, but I only found backend test code. Did I look at the wrong place?

Our front-end tests are very basic at the moment. We only have a few snapshot tests for a couple of components. Let's try to get more in when @menghif's work gets added.