Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase backoff attempts/delay before marking feed invalid #2335

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Oct 4, 2021

Fixes #2332.

This does two things to help avoid marking (probably) valid feeds as invalid when they fail for some reason (e.g., temporary network outage):

  1. Increases the backoff delay to 10 minutes
  2. Increases the number of retries to 10

What this means is that if a feed fails, we'll do the following:

  1. Try again in 10 minutes
  2. Try again in 30 minutes
  3. Try again in ~1 hour
  4. Try again in ~2.5 hours
  5. Try again in ~5 hours
  6. Try again in ~10 hours
  7. Try again in ~21 hours
  8. Try again in ~1.7 days
  9. Try again in ~3.5 days
  10. Try again in ~7 days
  11. Try again in ~14 days
  12. Try again in ~28 days

After a month, I think it's safe to assume this site is not coming back online, and we can mark it invalid.

@c3ho c3ho self-requested a review October 5, 2021 05:35
@humphd humphd merged commit 5096052 into Seneca-CDOT:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser is too aggressive with marking feeds invalid
3 participants