chore: bump passport-saml to v3.1.2 #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
added
area: back-end
Priority: High
type: security
manekenpix
requested review from
humphd,
chrispinkney,
c3ho and
PedroFonsecaDEV
|
This looks good, but I'm concerned about the test failure. I've re-triggered CI |
humphd
requested changes
Sep 3, 2021
jest.config.base.js
Outdated
| @@ -10,4 +10,5 @@ module.exports = { | |||
| moduleDirectories: ['node_modules'], | |||
| automock: false, | |||
| testTimeout: 10000, | |||
| testEnvironment: 'node', | |||
There was a problem hiding this comment.
I think this change is breaking the Playwright tests, such that it doesn't have the right browser environment.
There was a problem hiding this comment.
I changed the way to add that to make it work with both unit and e2e.
manekenpix
force-pushed
the
passport-saml
branch
from
a0354ef to
e0d8eac
Compare
manekenpix
force-pushed
the
passport-saml
branch
from
e0d8eac to
bb2d51c
Compare
humphd
requested changes
Sep 4, 2021
test/feeds-atom.test.js
Outdated
| @@ -1,3 +1,7 @@ | |||
| /** | |||
There was a problem hiding this comment.
Why not specify this env once in the config for these test files here https://github.com/Seneca-CDOT/telescope/blob/master/test/jest.config.js?
There was a problem hiding this comment.
Thanks for the suggestion! I added the env to jest.config.js and now all the tests pass.
manekenpix
force-pushed
the
passport-saml
branch
from
bb2d51c to
0d83a3d
Compare
cindyorangis
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps
passport-samlto version 3.1.2 to get rid of this depandabot alert.Checklist