Add authentication middleware to feed-discovery, refactor and update test coverage to 100%

[humphd]

I've updated the feed-parser service to require a user to be authenticated. I think it's a bit of a security risk to leave this open on the internet for anyone to hit, since it will download code from any URL you give it. Now you need to login first, but then any Seneca/Telescope user can do it (e.g., during signup).

Writing the code, I had to adjust a few things:

• rename lib -> middleware
• rework the middleware so that all functions return a middleware function (more standard way that we're doing this through the rest of the code)
• update the middleware tests to not need supertest
• added more test cases to get test coverage to 100% (woo!)
• updated all route tests to use a service token.

[PedroFonsecaDEV]

👍

[humphd]

I can't seem to get CI to pass, it's failing with this bizarre error:

FAIL src/api/users/test/e2e/users.test.js
  ● Test suite failed to run

    Cannot find module '@firebase/app-exp' from 'src/api/users/node_modules/firebase/node_modules/@firebase/database/dist/index.node.cjs.js'

    Require stack:
      src/api/users/node_modules/firebase/node_modules/@firebase/database/dist/index.node.cjs.js
      src/api/users/node_modules/firebase/dist/index.node.cjs.js
      src/api/users/node_modules/@firebase/rules-unit-testing/dist/index.cjs.js
      src/api/users/test/e2e/users.test.js

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (src/api/users/node_modules/firebase/node_modules/@firebase/database/dist/index.node.cjs.js:8:14)

This is unrelated to what I'm touching, so I have no idea what's happening. I wonder if it's npm cache on GitHub's side? I'll try re-triggering again in a bit, see if it sorts itself out.