-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PWA #2033
Added PWA #2033
Conversation
@tonyvugithub please add more details to this beyond "Ongoing process..." |
If this is ready for review, remove Draft and let me know. |
@humphd : I am still adding some screenshots and it should be ready for reviewing |
a5942b4
to
7b8a08f
Compare
@humphd , @chrispinkney The conflict problem is bigger than I thought. So far none of my attempt has worked. Should we consider upgrade |
I feel like we're hitting a lot of bugs that relate to About, and not actually doing a ton with it. I'm fine to alter how it works for sure. |
@huynguyez : Actually it is the icon that has the square background https://github.com/Seneca-CDOT/telescope/blob/master/src/web/public/logoImages/manifest-icon-192.png. |
@huynguyez Congrats @tonyvugithub, let's land this. |
Based on conversation on Slack, we agreed that we are going to wait on the response from the next PWA maintainer about how the update path works. If things will be OK, and not require custom UI from us, this is probably good to land. |
@humphd He should reply me next couple of days as he still actively maintains the repo. |
@PedroFonsecaDEV @chrispinkney @humphd : The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can try this, and iterate on it later. One thing we could do that I notice is add caching for our posts api, so they get saved at runtime for offline access later.
@humphd That was sth I have in mind too as I know the image is cached but not the posts. However, it would require more research into the matter. I can always do a follow up in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
Issue This PR Addresses
Fixed #801
Type of Change
Description
This PR turns our Telescope into a Progressive Web App (PWA) to improve user experience on mobile.
Reference: https://github.com/vercel/next.js/tree/canary/examples/progressive-web-app
Choose
Install app
on ChromeChecklist