Fixes: 1672 - [next] Investigate bugs related to Fonts.

[PedroFonsecaDEV]

Issue This PR Addresses

Fixes: #1672

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

The font on the PR #1667 before and after the fix:
BEFORE:

AFTER:

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[humphd]

Nice catch.

[birtony]

I have looked up the typeface-roboto package and it looks like typeface has been deprecated: https://github.com/KyleAMathews/typefaces/blob/master/packages/roboto/README.md. Could we use fontsource-roboto instead? @PedroFonsecaDEV

[humphd]

The Typefaces project is now deprecated.

NO!!!!!!! I loved this project. Thanks for spotting this, @birtony.

[PedroFonsecaDEV]

The new font has a different weight.
I think we can land this to have the same font as gatsby, then we move to a non-deprecated font on the new UI.

@birtony @humphd

[birtony]

@PedroFonsecaDEV do you think we could set the default font-weight in our global CSS styles and stick to fontsource-roboto?

[PedroFonsecaDEV]

Hey @birtony,
Since all our styles (including the font) are about to change, my advice will be to keep the old font until there. Because if we change it, it will change globally. Some texts will be impacted, like our header fonts.

[birtony]

Hey @birtony,
Since all our styles (including the font) are about to change, my advice will be to keep the old font until there. Because if we change it, it will change globally. Some texts will be impacted, like our header fonts.

Okay, that makes sense. In this case, could you, please, file an issue regarding the deprecated dependency before we merge this PR @PedroFonsecaDEV?

[PedroFonsecaDEV]

Hey @birtony,
Since all our styles (including the font) are about to change, my advice will be to keep the old font until there. Because if we change it, it will change globally. Some texts will be impacted, like our header fonts.

Okay, that makes sense. In this case, could you, please, file an issue regarding the deprecated dependency before we merge this PR @PedroFonsecaDEV?

Sure.
Follow the issue: #1686