-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Logo #1665
feat: New Logo #1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely Stunning. I really like the new logo. Minimalism, the Telescope looks like a T.
Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new logo looks great @PedroFonsecaDEV! Could you also optimize it with https://jakearchibald.github.io/svgomg/, please?
Agree with Anton. Other than that, looks amazing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Pedro for the hard work, this is amazing 😄
@birtony @HyperTHD @yuanLeeMidori @Metropass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this.
Can we take this opportunity to generate all the icon sizes and types we'll need? Instead of the logo2.0.png you have now, let's do all the sizes based on this new one.
Tools like https://app-manifest.firebaseapp.com/ or https://www.pwabuilder.com/ can help do this, or we could add a script to our build with something like https://www.npmjs.com/package/pwa-asset-generator.
We end up needing like 12 different sizes and types by the time we are done, especially for #801.
|
Silly question but why are the images called 'apple-*'? Is that an image convention? And I could be wrong but I think we will need an actual .svg file for icons or favicons too |
Hey @cindyledev we have the SVG file, but these images are related to PWA conventions. |
Thank you, I understand now :) |
Wow, that's a lot of additions since last time I reviewed! 👍🏼@PedroFonsecaDEV I'm sorry for late response, had computer detox yesterday |
Issue This PR Addresses
Fixes: #1664
Type of Change
Description
Checklist