Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Logo #1665

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Conversation

PedroFonsecaDEV
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV commented Feb 6, 2021

Issue This PR Addresses

Fixes: #1664

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Screen Shot 2021-02-05 at 8 04 05 PM

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Metropass
Metropass previously approved these changes Feb 6, 2021
Copy link
Contributor

@Metropass Metropass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely Stunning. I really like the new logo. Minimalism, the Telescope looks like a T.
Well done!

Copy link
Contributor

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new logo looks great @PedroFonsecaDEV! Could you also optimize it with https://jakearchibald.github.io/svgomg/, please?

@HyperTHD
Copy link
Contributor

HyperTHD commented Feb 6, 2021

Agree with Anton. Other than that, looks amazing

yuanLeeMidori
yuanLeeMidori previously approved these changes Feb 6, 2021
Copy link
Contributor

@yuanLeeMidori yuanLeeMidori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pedro for the hard work, this is amazing 😄

@PedroFonsecaDEV
Copy link
Contributor Author

@birtony @HyperTHD @yuanLeeMidori @Metropass
Sorry guys I had a bad time dealing with the SVG file, but now the SVG is good and optimized.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this.

Can we take this opportunity to generate all the icon sizes and types we'll need? Instead of the logo2.0.png you have now, let's do all the sizes based on this new one.

Tools like https://app-manifest.firebaseapp.com/ or https://www.pwabuilder.com/ can help do this, or we could add a script to our build with something like https://www.npmjs.com/package/pwa-asset-generator.

We end up needing like 12 different sizes and types by the time we are done, especially for #801.

@PedroFonsecaDEV
Copy link
Contributor Author

PedroFonsecaDEV commented Feb 6, 2021

Love this.

Can we take this opportunity to generate all the icon sizes and types we'll need? Instead of the logo2.0.png you have now, let's do all the sizes based on this new one.

Tools like https://app-manifest.firebaseapp.com/ or https://www.pwabuilder.com/ can help do this, or we could add a script to our build with something like https://www.npmjs.com/package/pwa-asset-generator.

We end up needing like 12 different sizes and types by the time we are done, especially for #801.

Done!
Screen Shot 2021-02-06 at 6 44 05 PM

@cindyorangis
Copy link
Contributor

Silly question but why are the images called 'apple-*'? Is that an image convention? And I could be wrong but I think we will need an actual .svg file for icons or favicons too

@PedroFonsecaDEV
Copy link
Contributor Author

Silly question but why are the images called 'apple-*'? Is that an image convention? And I could be wrong but I think we will need an actual .svg file for icons or favicons too

Hey @cindyledev we have the SVG file, but these images are related to PWA conventions.
"When you build a PWA with a goal of providing native-like experiences on multiple platforms and stores, you need to meet with the criteria of those platforms and stores with your PWA assets; icon sizes and splash screens."
you can check for more information: pwa-asset-generator

@PedroFonsecaDEV PedroFonsecaDEV merged commit af3f6bf into Seneca-CDOT:master Feb 7, 2021
@cindyorangis
Copy link
Contributor

Silly question but why are the images called 'apple-*'? Is that an image convention? And I could be wrong but I think we will need an actual .svg file for icons or favicons too

Hey @cindyledev we have the SVG file, but these images are related to PWA conventions.
"When you build a PWA with a goal of providing native-like experiences on multiple platforms and stores, you need to meet with the criteria of those platforms and stores with your PWA assets; icon sizes and splash screens."
you can check for more information: pwa-asset-generator

Thank you, I understand now :)

@birtony
Copy link
Contributor

birtony commented Feb 7, 2021

Wow, that's a lot of additions since last time I reviewed! 👍🏼@PedroFonsecaDEV I'm sorry for late response, had computer detox yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Issues needing design or assets area: front-end area: nextjs Nextjs related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] New Logo
7 participants