Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue-1424 : Fix colours in GitHub Contributor component #1430

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Fix issue-1424 : Fix colours in GitHub Contributor component #1430

merged 1 commit into from
Nov 21, 2020

Conversation

tianlangwu
Copy link
Contributor

@tianlangwu tianlangwu commented Nov 20, 2020 •
edited
Loading

Issue This PR Addresses

Fix #1424

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Fixed font colours in GitHub Contributor component. Replaced the colour to the same "white" as the rest of the footer.
Removed unnecessary import and variable.
Fixed a linter error.
Thanks for your consideration!

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@PedroFonsecaDEV PedroFonsecaDEV self-requested a review November 20, 2020 06:02
PedroFonsecaDEV
PedroFonsecaDEV previously approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroFonsecaDEV
Copy link
Contributor

Just some considerations:

  1. Don't forget to self-assign to issue (so we know who is working on what and so on)
  2. Please edit the title of the PR for our pattern (Fixes issue-0000: title of the issue)

Please rebase this brach.

@tianlangwu tianlangwu changed the title Fix font colours in GitHub Contributor component Fix Issue-1424 : fix colours in GitHub Contributor component Nov 20, 2020
@tianlangwu
Copy link
Contributor Author

Just some considerations:

  1. Don't forget to self-assign to issue (so we know who is working on what and so on)
  2. Please edit the title of the PR for our pattern (Fixes issue-0000: title of the issue)

Please rebase this brach.

Thanks for the advice, I will rebase it later.

@tianlangwu tianlangwu changed the title Fix Issue-1424 : fix colours in GitHub Contributor component Fix issue-1424 : Fix colours in GitHub Contributor component Nov 20, 2020
humphd
humphd reviewed Nov 21, 2020
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we're using dark-on-dark here for the plain text, it's so dark:

Screen Shot 2020-11-21 at 9 42 50 AM

Question: the whole footer is white, so why not use white everywhere here, and just provide underlines for the anchors?

@tianlangwu
Copy link
Contributor Author

I don't understand why we're using dark-on-dark here for the plain text, it's so dark:

Screen Shot 2020-11-21 at 9 42 50 AM

Question: the whole footer is white, so why not use white everywhere here, and just provide underlines for the anchors?

Agree, I will change the text colour to white.

@tianlangwu
Fix font colours in GitHub Contributor component
168b1d6 
Remove unnecessary import and variable
Fix a linter error
@PedroFonsecaDEV PedroFonsecaDEV merged commit 3e8e98f into Seneca-CDOT:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@humphd humphd humphd approved these changes

@Wei-J-Huang Wei-J-Huang Awaiting requested review from Wei-J-Huang

@lixiaoqity lixiaoqity Awaiting requested review from lixiaoqity

@MLJBrackett MLJBrackett Awaiting requested review from MLJBrackett

@MSTEWARDSON MSTEWARDSON Awaiting requested review from MSTEWARDSON

@sanji11 sanji11 Awaiting requested review from sanji11

@yuanLeeMidori yuanLeeMidori Awaiting requested review from yuanLeeMidori

@agarcia-caicedo agarcia-caicedo Awaiting requested review from agarcia-caicedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix font colours in GitHub Contributor component
4 participants
@tianlangwu @PedroFonsecaDEV @humphd @agarcia-caicedo