-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issue-1180 fixes the post padding for mobile devices found in timeline.jsx #1292
Conversation
Sure, push another commit and let's do it here. |
I just added the commit that adds the scrollbar for overflown posts. Let me know, Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this
@pyvelkov Feel free to squash and merge |
would you like me to do it, or..? |
@pyvelkov go for it! With 2 reviews giving an approval, you can squash and merge. |
Issue This PR Addresses
Fixes #1180
Type of Change
Description
I traced how the padding was being applied through Chrome developer tools. I saw that the default root
padding
was being applied meaning the posts havepadding
to the left and right and were not being overridden as expected. From the previous fix that was made I saw that root style was being overridden with apadding
of 0 in posts.jsx but since the change in #1217 , timeline.jsx was created and that is where the issue stemmed from. I saw that the Timeline function was returning the wrapped array in a container that had theclassName={classes.root}
. However custom overriding of the root style was not being called in "useStyles".Before
After
EDIT:
I believe this also fixed #1226
I also ran
npm run test
and everything passed. Everything looks alright on my end.Let me know what you think and if this is what we are after in #1180 , my JS is terrible and I probably spent far longer than needed for something like this. I hope it is what we are after.
Checklist