Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove className="..." from Header.jsx #974

Closed
humphd opened this issue Apr 9, 2020 · 4 comments · Fixed by #1148
Closed

Remove className="..." from Header.jsx #974

humphd opened this issue Apr 9, 2020 · 4 comments · Fixed by #1148
Assignees
Labels
5 min fix Fixable in 5 minutes or less area: front-end good first issue Good for newcomers type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Apr 9, 2020

In src/frontend/src/components/Header/Header.jsx, we're using unnecessary className attributes. They can be removed:

 {matches ? <MobileHeader className="mobile-header" /> : <DesktopHeader className="header" />}
@humphd humphd added type: bug Something isn't working good first issue Good for newcomers area: front-end 5 min fix Fixable in 5 minutes or less labels Apr 9, 2020
@pyvelkov
Copy link
Contributor

pyvelkov commented Oct 2, 2020

Hey,
I'm willing to give this a shot. Can I take a crack at this?

@c3ho
Copy link
Contributor

c3ho commented Oct 2, 2020

Yep, go ahead! I’ll assign this to you as soon as I find out how to do it on mobile

@PedroFonsecaDEV
Copy link
Contributor

Can I give a try?

@manekenpix
Copy link
Member

@PedroFonsecaDEV yes, thank you!

manekenpix added a commit that referenced this issue Oct 2, 2020
Fixes #974: Remove className="..." from Header.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: front-end good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants