Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeds.js - Routes and Test need to include Protect #734

Closed
Grommers00 opened this issue Feb 17, 2020 · 0 comments · Fixed by #915
Closed

Feeds.js - Routes and Test need to include Protect #734

Grommers00 opened this issue Feb 17, 2020 · 0 comments · Fixed by #915
Assignees
Labels
area: back-end type: bug Something isn't working

Comments

@Grommers00
Copy link
Contributor

What happened:
Feeds.js in src\backend\web\routes\feeds.js and test\feeds.test.js both need to be updated
once we get protect working on the back end and we can test accordingly.

What should have happened:
Protect should be put on the post route, and this will affect the tests at the same time.

How to reproduce it (as precise as possible):
You can test by not logging in and still using the post route on our express server, this shouldn't be the case. We should not move ahead though with adding protect as it will cause tests to fail.
Anything else we need to know?:
This will be a future fix.

@Grommers00 Grommers00 added type: bug Something isn't working area: back-end labels Feb 17, 2020
humphd added a commit to humphd/telescope that referenced this issue Apr 1, 2020
humphd added a commit to humphd/telescope that referenced this issue Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: back-end type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants