Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure frontend components to include logic and style in component directory #584

Closed
miggs125 opened this issue Jan 22, 2020 · 1 comment
Closed

Restructure frontend components to include logic and style in component directory #584

miggs125 opened this issue Jan 22, 2020 · 1 comment
Assignees
@miggs125
Labels
area: front-end type: enhancement New feature or request

Comments

@miggs125
Copy link
Contributor

What would you like to be added:
Previously, style had been separated from react logic but as we are removing sass, we can restructure the frontend directory to include both logic and style, thereby keeping all parts of the component together

Why would you like this to be added:
This would make it easier to remove and replace components without too much stuff breaking. It also makes debugging a little easier.

This issue references #541
@miggs125 miggs125 mentioned this issue Feb 4, 2020
Merged
8 tasks
miggs125 added a commit that referenced this issue Feb 5, 2020
@miggs125
Merge pull request #647 from miggs125/restructureFrontEnd
4260501 
Restructure front end. closes #583 #584
@cindyorangis
Copy link
Contributor

Closing. PR has merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miggs125 miggs125

Labels
area: front-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miggs125 @cindyorangis