Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GraphQL implementation #552

Closed
manekenpix opened this issue Jan 19, 2020 · 7 comments · Fixed by #1295
Closed

Remove GraphQL implementation #552

manekenpix opened this issue Jan 19, 2020 · 7 comments · Fixed by #1295
Assignees
@manekenpix
Labels
area: back-end area: web server Issues related to the web server

Comments

@manekenpix
Copy link
Member

manekenpix commented Jan 19, 2020 •
edited
Loading

What would you like to be added:

Our backend will soon incorporate GraphQL support (#532 ) and we'll need tests for queries requesting both feeds and posts.

Here is a module for testing developed by the Apollo-server community.

Another possibility could be easygraphql-tester.

Why would you like this to be added:

We need to make sure that our GraphQL endpoint answers queries correctly.
@manekenpix manekenpix added area: back-end type: test Creation and development of test area: web server Issues related to the web server labels Jan 19, 2020
@c3ho c3ho self-assigned this Jan 21, 2020
c3ho added a commit to c3ho/telescope that referenced this issue Jan 29, 2020
@c3ho
Fixes Seneca-CDOT#552, add tests for graphql
d56564f
@c3ho c3ho removed their assignment Mar 2, 2020
@c3ho
Copy link
Contributor

c3ho commented Mar 2, 2020

Let's have this finished prior to 1.0

@manekenpix
Copy link
Member Author

manekenpix commented Oct 12, 2020 •
edited
Loading

I was planning to do some work on this, but after seeing comments and discussions on slack, maybe we should close this and start thinking about a new front-tend. Thoughts?

@humphd
Copy link
Contributor

humphd commented Oct 12, 2020

I think tests for the REST API and GraphQL endpoints would be good for any/all frontends we do, no? I can't see a downside to you working on this.

Or, if you would rather, spec it out as bugs other students could do?

@manekenpix
Copy link
Member Author

It's just that it seems our REST API fits better with the way Telescope works, and maybe we're going to end up removing all our GraphQL code (we barely use it), that's why I wasn't sure about spending time on this.

@humphd
Copy link
Contributor

humphd commented Oct 12, 2020

That's another way to go: rip it all out. We should discuss with people and see what the consensus is.

I could go either way.

@humphd humphd changed the title Add test for GraphQL implementation Remove GraphQL implementation Nov 1, 2020
@humphd
Copy link
Contributor

humphd commented Nov 1, 2020

Morphing this to be about removing GraphQL, since we don't need it for next.js.

@c3ho
Copy link
Contributor

c3ho commented Nov 1, 2020

image

@manekenpix manekenpix removed the type: test Creation and development of test label Nov 5, 2020
@manekenpix manekenpix mentioned this issue Nov 6, 2020
Merged
4 tasks
manekenpix added a commit that referenced this issue Nov 10, 2020
@manekenpix
Merge pull request #1295 from manekenpix/issues/552-remove-graphql
87075df 
Closes #552: Remove GraphQL implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manekenpix manekenpix

Labels
area: back-end area: web server Issues related to the web server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #552: Remove GraphQL implementation manekenpix/telescope
3 participants
@humphd @c3ho @manekenpix