Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip title to TelescopeAvatar, use with GitHub User component #2442

Closed
humphd opened this issue Nov 3, 2021 · 1 comment · Fixed by #2447
Closed

Add tooltip title to TelescopeAvatar, use with GitHub User component #2442

humphd opened this issue Nov 3, 2021 · 1 comment · Fixed by #2447
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Nov 3, 2021

In #2430 we're adding a GitHub user avatar. We want to be able to pass down the username and have it be used as a title attribute, so you can hover and see the name.

In https://github.com/Seneca-CDOT/telescope/blob/master/src/web/src/components/TelescopeAvatar.tsx#L49 it looks like it's setting alt but not title. Let's fix that, then use it for all the places we use the TelescopeAvatar component.
@humphd humphd added type: enhancement New feature or request area: front-end area: accessibility Making Telescope accessible for all kinds of users labels Nov 3, 2021
@humphd humphd mentioned this issue Nov 3, 2021
Merged
8 tasks
@humphd
Copy link
Contributor Author

humphd commented Nov 3, 2021

Let's make the TelescopeAvatar get wrapped in a link so it's clickable, then it will fix a few issues we have.

@HyperTHD HyperTHD mentioned this issue Nov 3, 2021
Merged
8 tasks
HyperTHD added a commit that referenced this issue Nov 3, 2021
@HyperTHD
Fixes #2442: Fixes linking of users icon, and adds title to users and…
98dcfc2 
… telescope avatar icons (#2447)

Removed window action, added title to user and avatar components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2442: Fixes linking of users icon, and adds title to users and telescope avatar icons
1 participant
@humphd