Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find module '../lib' from 'src/web/node_modules/react-icons/fa/index.js' #2324

Closed
humphd opened this issue Oct 2, 2021 · 2 comments · Fixed by #2326
Closed

Cannot find module '../lib' from 'src/web/node_modules/react-icons/fa/index.js' #2324

humphd opened this issue Oct 2, 2021 · 2 comments · Fixed by #2326
Assignees
@manekenpix
Labels
dependencies Pull requests that update a dependency file type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Oct 2, 2021

After landing @DukeManh's recent PR, we're failing on master with:

FAIL src/web/src/components/AboutFooter.test.tsx
  ● Test suite failed to run

    Cannot find module '../lib' from 'src/web/node_modules/react-icons/fa/index.js'

    Require stack:
      src/web/node_modules/react-icons/fa/index.js
      src/web/src/components/AboutFooter.tsx
      src/web/src/components/AboutFooter.test.tsx

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (src/web/node_modules/react-icons/fa/index.js:2:15)

  console.warn
PASS src/web/src/components/Logo.test.tsx
  ✓ renders correctly (23 ms)

    Material-UI: The `css` function is deprecated. Use the `styleFunctionSx` instead.

      at css (src/web/node_modules/@material-ui/system/styleFunctionSx.js:75:13)
      at Object.<anonymous> (src/web/node_modules/@material-ui/core/Box/Box.js:14:37)
      at Object.<anonymous> (src/web/node_modules/@material-ui/core/Box/index.js:21:36)

Summary of all failing tests
FAIL src/web/src/components/AboutFooter.test.tsx
  ● Test suite failed to run

    Cannot find module '../lib' from 'src/web/node_modules/react-icons/fa/index.js'

    Require stack:
      src/web/node_modules/react-icons/fa/index.js
      src/web/src/components/AboutFooter.tsx
      src/web/src/components/AboutFooter.test.tsx

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (src/web/node_modules/react-icons/fa/index.js:2:15)

I don't think they are related, but I don't understand this either.
@humphd humphd added type: bug Something isn't working area: CI/CD Continuous integration / Continuous delivery type: test Creation and development of test labels Oct 2, 2021
@humphd
Copy link
Contributor Author

humphd commented Oct 2, 2021

See https://github.com/Seneca-CDOT/telescope/runs/3778501984. I've re-triggered the builds.

@humphd
Copy link
Contributor Author

humphd commented Oct 2, 2021

Looks like upstream breakage: react-icons/react-icons#490

@humphd humphd added dependencies Pull requests that update a dependency file and removed area: CI/CD Continuous integration / Continuous delivery type: test Creation and development of test labels Oct 2, 2021
@manekenpix manekenpix self-assigned this Oct 2, 2021
This was referenced Oct 2, 2021
Merged
Merged
manekenpix added a commit that referenced this issue Oct 2, 2021
@manekenpix
Merge pull request #2326 from manekenpix/react-icons-fix
c38f1b1 
Fixes #2324: Cannot find module '../lib' from 'src/web/node_modules/react-icons/fa/index.js'
@humphd humphd mentioned this issue Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manekenpix manekenpix

Labels
dependencies Pull requests that update a dependency file type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@humphd @manekenpix