Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default components being merged with user-defined components #1645

Closed
wants to merge 5 commits into from

Conversation

kurbar
Copy link
Contributor

@kurbar kurbar commented Jan 16, 2015

Hello,

Currently when you have only a few components defined in your semantic.json file, it also merges the other components on top of the selected components from defaults.

The issue with it is, if you want to compile a custom semantic build without all of the components, it's not possible. This is due to the deep copy been set to true for extend.

Setting it to false allows you to compile a semantic build with only the components you want.

@jlukic
Copy link
Member

jlukic commented Jan 16, 2015

I just need to verify this doesn't effect any other settings that might need extend to be deep.

@jlukic
Copy link
Member

jlukic commented Jan 16, 2015

Everything's good. The PR has some extra commits, manually merging in fix. 1.7.3

@jlukic jlukic closed this Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants