Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try/catch in tasks/config/project/release.js covers too many cases. #2875

Closed
Parakleta opened this issue Aug 19, 2015 · 1 comment
Closed
Milestone

Comments

@Parakleta
Copy link

The try/catch block in tasks/config/project/release.js will bail to catch if either semantic.json or package.json is missing, whereas it should only do this if both are missing.

The changes introduced to this file in 57b35d2 need to be moved after the try/catch into a separate try/catch block. Note also that this commit stores the version in the variable version whereas the value exported is package.version.

@jlukic
Copy link
Member

jlukic commented Aug 19, 2015

Yeah this looks wrong. I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants