Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading button should be disabled #1744

Closed
mderazon opened this issue Feb 2, 2015 · 7 comments
Closed

Loading button should be disabled #1744

mderazon opened this issue Feb 2, 2015 · 7 comments
Milestone

Comments

@mderazon
Copy link

mderazon commented Feb 2, 2015

I think that a loading button should also be disabled (without additional styling). I find it a much more common use case than a loading button that can be interacted with.
Moreover, achieving both is not possible by simply setting disabled loading since disabled changes the color of the button. So if I have a colored loading button, setting disabled makes it grey.

If making this breaking change is impossible, then perhaps introduce a new attribute muted (disabled and active were taken :) ) that when added will achieve the same...

What do you think ?

@p-hennessy
Copy link
Contributor

+1

@jlukic
Copy link
Member

jlukic commented Feb 4, 2015

When you say disabled do you mean specifically point-events: none; which disables events from occurring on the element?

@p-hennessy
Copy link
Contributor

@jlukic: I think he means when it has class loading, the button should not have hover or active states as to not give the user the impression that they can still interact with the button.

@mderazon
Copy link
Author

mderazon commented Feb 4, 2015

Yes, like @ph7vc wrote but perhapes also not fire any mouse / click events. I guess pointer-events: none; achieves exactly that ?

@jlukic
Copy link
Member

jlukic commented Feb 4, 2015

I understand. I'll take a look at loading buttons again in the default theme.

Perhaps there's some middle ground for loading thats an opacity a notch above disabled. At the very least it should be a variable.

@jlukic jlukic added this to the 1.9.0 milestone Feb 4, 2015
@jlukic jlukic removed the Discussion label Feb 4, 2015
jlukic added a commit that referenced this issue Feb 9, 2015
@jlukic
Copy link
Member

jlukic commented Feb 9, 2015

Loading will no longer receive events in default theme.

Added variables for loading opacity and pointer-events.

Available in next

@jlukic jlukic closed this as completed Feb 9, 2015
@mderazon
Copy link
Author

Awesome, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants