Skip to content

Commit

Permalink
#3148 fixes default setting name for onEnabled to match typo name
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Nov 30, 2015
1 parent 1062ce9 commit 740b0d1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Version 2.1.7 Nov 29, 2015

**Bug Fixes**
-**Popup** - Fixed issue with `onEnable` callback being defined with name `onEnabled` and `onDisable` with `onDisabled` in default settings, causing an error. To preserve backwards compatibility, the mispelled callback name has been left, but the bug has been fixed. #3148
-**Popup** - Adds `onUnplaceable` callback when element cannot be place in visible screen #3388
-**Sidebar** - Sidebar no longer includes `transform` rules on child elements, this was causing layout issues in some cases (for example dropdowns in sidebars) #3306
-**Sidebar** - Fixed css rule issue causing `very thin` sidebar to not work #3300
Expand Down
8 changes: 4 additions & 4 deletions src/definitions/modules/checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ $.fn.checkbox = function(parameters) {
}
module.debug('Enabling checkbox');
module.set.enabled();
settings.onEnable.call(input);
settings.onEnabled.call(input);
},

disable: function() {
Expand All @@ -278,7 +278,7 @@ $.fn.checkbox = function(parameters) {
}
module.debug('Disabling checkbox');
module.set.disabled();
settings.onDisable.call(input);
settings.onDisabled.call(input);
},

get: {
Expand Down Expand Up @@ -781,8 +781,8 @@ $.fn.checkbox.settings = {
onDeterminate : function() {},
onIndeterminate : function() {},

onEnabled : function(){},
onDisabled : function(){},
onEnable : function(){},
onDisable : function(){},

className : {
checked : 'checked',
Expand Down

0 comments on commit 740b0d1

Please sign in to comment.