Clean up logic in onComplete for cogency #2713

Semantic-Org · Jul 23, 2015 · 66c89ad · 66c89ad
1 parent 7849999
commit 66c89ad
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/definitions/behaviors/api.js b/src/definitions/behaviors/api.js
@@ -514,11 +514,20 @@ $.api = $.fn.api = function(parameters) {
               }
               settings.onSuccess.call(context, response, $module, xhr);
             },
-            complete: function(maybeResponse, xhr) {
+            complete: function(firstParameter, secondParameter) {
               var
-                // ajax deferred returns either response or xhr depending on success/fail
-                response = module.get.responseFromXHR(maybeResponse)
+                xhr,
+                response
               ;
+              // have to guess callback parameters based on request success
+              if( module.was.succesful() ) {
+                response = firstParameter;
+                xhr      = secondParameter;
+              }
+              else {
+                xhr      = firstParameter;
+                response = module.get.responseFromXHR(xhr);
+              }
               module.remove.loading();
               settings.onComplete.call(context, response, $module, xhr);
             },