Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tableheadercell): add collapsing #1399

Closed
wants to merge 6 commits into from
Closed

Conversation

DomiR
Copy link

@DomiR DomiR commented Feb 28, 2017

Collapsing is missing from headercells.

Collapsing is missing from headercells.
@levithomason
Copy link
Member

Thanks, we'll also need to update the index.d.ts file in this directory as well as add a test call in TableHeader-test.js.

@levithomason
Copy link
Member

Nice, just need a common test now.

@layershifter
Copy link
Member

@levithomason Wait a second there. TableHeaderCell is only simple wrapper around TableCell, so collapsing prop will be pass as unhandled.

So, I think it's job for #1169. It's already done in the typings.

@levithomason
Copy link
Member

This is true, however, there is also a className and CSS rule for it:

/*--------------
    Collapsing
---------------*/

.ui.table th.collapsing,
.ui.table td.collapsing {
  width: 1px;
  white-space: nowrap;
}

@layershifter
Copy link
Member

@levithomason It's not the single property that th has in CSS. I still think that it's not best idea to handle collapsing prop in TableHeaderCell while we handle it too in child TableCell.

@levithomason
Copy link
Member

I see what you're saying, the header cell composes the regular cell.

This plays into #1169. There is no documentation visibility with the inheritance here. We could handle this by only adding the propTypes for it, or, pending the babel plugin update for unhandled props, we could spead the cell prop types and update the docs to show "composes" propTypes as well.

@levithomason
Copy link
Member

levithomason commented Mar 12, 2017

Note that this prop is supported as it is passed to the underlying TableCell. Typings extend the TableCell props as well, so there is support there. Lastly, we're very close to finishing updates to the doc site to show inherited or "composed" propTypes as well, track #1169.

Appreciate the notice and PR here. Closing this PR in favor of those efforts.

@DomiR DomiR deleted the patch-2 branch March 12, 2017 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants