-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tableheadercell): add collapsing #1399
Conversation
Collapsing is missing from headercells.
Thanks, we'll also need to update the |
Nice, just need a common test now. |
@levithomason Wait a second there. So, I think it's job for #1169. It's already done in the typings. |
This is true, however, there is also a className and CSS rule for it: /*--------------
Collapsing
---------------*/
.ui.table th.collapsing,
.ui.table td.collapsing {
width: 1px;
white-space: nowrap;
} |
@levithomason It's not the single property that |
I see what you're saying, the header cell composes the regular cell. This plays into #1169. There is no documentation visibility with the inheritance here. We could handle this by only adding the propTypes for it, or, pending the babel plugin update for unhandled props, we could spead the cell prop types and update the docs to show "composes" propTypes as well. |
Note that this prop is supported as it is passed to the underlying TableCell. Typings extend the TableCell props as well, so there is support there. Lastly, we're very close to finishing updates to the doc site to show inherited or "composed" propTypes as well, track #1169. Appreciate the notice and PR here. Closing this PR in favor of those efforts. |
Collapsing is missing from headercells.