style(Statistic): update typings and propTypes usage #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2017
Current coverage is 95.89% (diff: 100%)@@ master #1232 diff @@
==========================================
Files 880 880
Lines 4901 4901
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4700 4700
Misses 201 201
Partials 0 0
|
checkmatez
reviewed
Jan 26, 2017
| @@ -16,26 +16,36 @@ import StatisticLabel from './StatisticLabel' | |||
| import StatisticValue from './StatisticValue' | |||
|
|
|||
| /** | |||
| * A statistic emphasizes the current value of an attribute | |||
| * A statistic emphasizes the current value of an attributeю | |||
levithomason
approved these changes
Jan 27, 2017
|
💥 |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
* style(Statistic): update typings and propTypes usage * style(Statistic): update typings and propTypes usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.