style(Checkbox|Flag|Image|Radio): propTypes cleanups and typings update #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
layershifter
force-pushed
the
style/proptypes-cleanups
branch
from
0d7d1cf to
217aa84
Compare
layershifter
force-pushed
the
style/proptypes-cleanups
branch
from
217aa84 to
5652ee5
Compare
layershifter
commented
Jan 13, 2017
| @@ -53,9 +53,12 @@ const names = [ | |||
| 'ye', 'yemen', 'yt', 'mayotte', 'za', 'south africa', 'zm', 'zambia', 'zw', 'zimbabwe', | |||
| ] | |||
|
|
|||
| /** | |||
| * A flag is is used to represent a political state. | |||
| **/ | |||
There was a problem hiding this comment.
Added description 😄
There was a problem hiding this comment.
The closing tag for a doc block only needs one asterisk:
/**
* ...
*/There was a problem hiding this comment.
Also updated other doc blocks.
layershifter
commented
Jan 13, 2017
| function Flag(props) { | ||
| const { className, name } = props | ||
| const classes = cx(name, className, 'flag') | ||
| const classes = cx(name, 'flag', className) |
layershifter
commented
Jan 13, 2017
| } | ||
|
|
||
| Radio.propTypes = { | ||
| /** Format to emphasize the current selection state */ | ||
| /** Format to emphasize the current selection state. */ |
layershifter
commented
Jan 13, 2017
| type?: 'checkbox' | 'radio'; | ||
| } | ||
|
|
||
| export const Radio: React.StatelessComponent<RadioProps>; |
There was a problem hiding this comment.
New typings for Radio.
layershifter
commented
Jan 13, 2017
| shallow(<Component { ...requiredProps } verticalAlign={propVal} />) | ||
| .should.have.className(`${propVal} ${'aligned'}`) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
We don't have _meta.props now.
layershifter
commented
Jan 13, 2017
|
|
||
| _.each(_.get(Component, `_meta.props[${propKey}]`), propVal => { | ||
| wrapper.should.not.have.className(propVal) | ||
| }) |
Current coverage is 95.88% (diff: 100%)
|
layershifter
changed the title
levithomason
requested changes
Jan 16, 2017
| } | ||
|
|
||
| Radio.propTypes = { | ||
| /** Format to emphasize the current selection state */ | ||
| /** Format to emphasize the current selection state. */ |
| @@ -53,9 +53,12 @@ const names = [ | |||
| 'ye', 'yemen', 'yt', 'mayotte', 'za', 'south africa', 'zm', 'zambia', 'zw', 'zimbabwe', | |||
| ] | |||
|
|
|||
| /** | |||
| * A flag is is used to represent a political state. | |||
| **/ | |||
There was a problem hiding this comment.
The closing tag for a doc block only needs one asterisk:
/**
* ...
*/| const { assertRequired } = commonTestHelpers('implementsVerticalAlignProp', Component) | ||
|
|
||
| describe('verticalAlign (common)', () => { | ||
| assertRequired(Component, 'a `Component`') | ||
|
|
||
| _noDefaultClassNameFromProp(Component, 'verticalAlign', options) | ||
| _noClassNameFromBoolProps(Component, 'verticalAlign', options) | ||
|
|
||
| _.each(Component._meta.props.verticalAlign, (propVal) => { |
There was a problem hiding this comment.
Let's implement a similar solution as we will do in #1165 (comment)
There was a problem hiding this comment.
Agree with this, will work on it.
|
|
||
| _.each(_.get(Component, `_meta.props[${propKey}]`), propVal => { | ||
| wrapper.should.not.have.className(propVal) | ||
| }) |
14 tasks
|
TODO: Check for #1169. |
4 tasks
|
I've updated |
levithomason
approved these changes
Jan 17, 2017
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.
Affects following components:
CheckboxFlagImageRadio