This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
version bump to v1.1.2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the android:versionCode to 4 (app/src/main/AndroidManifest.xml) * the android:versionName to 1.1.2 (app/src/main/AndroidManifest.xml)
guserav
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Please look at the remark. The current state with 1.1.2 is also good with me so I would place the decision on whether to use . or - for the last part of the version on @Happy86, as long as it will be consistent after this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump to v1.1.2 in accordance with the issue #5 (closes #5)
The merge commit will be tagged in the master branch once this is merged.
Also another commit with some blank lines for added consistency in README.md