Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut for enabling Firefox' headless mode #4762

Closed

Conversation

franzliedke
Copy link
Contributor

This provides a dedicated API for enabling headless mode. This is already possible via adding command-line arguments.

See #4591.

Please comment on whether using headless! conforms with your conventions. 😄
Do we need a way to disable this feature as well? Since there is no remove_argument, I would not assume so...

@lmtierney
Copy link
Member

LGTM, @p0deje ?

@titusfortner
Copy link
Member

titusfortner commented Sep 27, 2017

I'm against this idea. I don't think we should add a special method for each browser argument.

@franzliedke
Copy link
Contributor Author

@titusfortner Apparently, this was requested and not shot down in #4591.

@barancev barancev added the C-rb label Sep 28, 2017
@p0deje
Copy link
Member

p0deje commented Sep 29, 2017

Java bindings also provide this, so even I agree with @titusfortner that we should not wrap every argument with custom method, I'm more concerned to make bindings API consistent to each other.

Thank you for contribution! Merged in a2a7634.

@p0deje p0deje closed this Sep 29, 2017
@barancev
Copy link
Member

headless is special :)

@jimevans
Copy link
Member

I’m not entirely sure I agree that “headless is special.” There is already a mechanism for passing arguments to a browser’s command line. There is no defensible reason to not include a type-safe switch for every command line argument of a browser, if an exception is made for one of them. I am perfectly happy with inconsistency between languages if that means the particular language binding’s API retains internal consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants