Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Add not-null Response.Value helper #15243

Merged
merged 9 commits into from
Feb 6, 2025
Merged

[dotnet] Add not-null Response.Value helper #15243

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9a76e89
[dotnet] Add not-null `Response.Value` helper
RenderMichael Feb 5, 2025
388d70f
Merge branch 'trunk' into not-null-response
RenderMichael Feb 5, 2025
44253d2
Use other style
RenderMichael Feb 5, 2025
8405247
Merge branch 'not-null-response' of https://github.com/RenderMichael/…
RenderMichael Feb 5, 2025
6369b4a
update method name
RenderMichael Feb 5, 2025
2877cce
add custom error message
RenderMichael Feb 5, 2025
47ebeb5
EnsureValueIsNotNull can return itself
RenderMichael Feb 5, 2025
857e238
Improve message
RenderMichael Feb 5, 2025
031f968
Improve message
RenderMichael Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions dotnet/src/webdriver/Response.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
using OpenQA.Selenium.Internal;
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Text.Json;
using System.Text.Json.Serialization;
Expand Down Expand Up @@ -215,6 +216,21 @@ public string ToJson()
return JsonSerializer.Serialize(this);
}

/// <summary>
/// Throws if <see cref="Value"/> is <see langword="null"/>.
/// </summary>
/// <exception cref="WebDriverException">If <see cref="Value"/> is <see langword="null"/>.</exception>
[MemberNotNull(nameof(Value))]
internal Response EnsureValueIsNotNull()
{
if (Value is null)
{
throw new WebDriverException("Response from remote end doesn't have $.Value property");
}

return this;
}

/// <summary>
/// Returns the object as a string.
/// </summary>
Expand Down
Loading