Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Align paket target framework with supported versions #15212

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Feb 1, 2025

User description

csproj and bazel are aligned, we use net8.0 and netstandard.

Motivation and Context

Align paket target frameworks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Updated paket.dependencies to align target frameworks.

  • Changed framework from net7.0 to net8.0.


Changes walkthrough 📝

Relevant files
Enhancement
paket.dependencies
Update target framework in `paket.dependencies`                   

dotnet/paket.dependencies

  • Updated the target framework from net7.0 to net8.0.
  • Ensured alignment with supported framework versions.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented Feb 1, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 1, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Ensure backward compatibility during upgrade

    Verify that all dependencies are compatible with .NET 8.0 before upgrading the
    target framework, as some packages might not have been updated yet.

    dotnet/paket.dependencies [2]

    -framework: net8.0,netstandard2.0
    +framework: net8.0,net7.0,netstandard2.0
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to maintain compatibility with net7.0 during the upgrade is valuable for ensuring a smoother transition and reducing potential breaking changes, especially if some dependencies haven't been updated for net8.0 yet.

    7

    @nvborisenko nvborisenko merged commit 07872eb into SeleniumHQ:trunk Feb 1, 2025
    10 checks passed
    @nvborisenko nvborisenko deleted the dotnet-paket-target branch February 3, 2025 19:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants