-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit reference to cdp types #15194
Add explicit reference to cdp types #15194
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Failures on Ruby are unrelated, merging |
a1f47e8
into
SeleniumHQ:dotnet-devtools-aot
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added configurable purge interval for dead nodes in Selenium Grid.
Updated Bazel dependencies to newer versions.
Enhanced .NET DevTools code generation with snake-case type names.
Improved test coverage for distributor and router functionalities.
Changes walkthrough 📝
7 files
Added purge nodes interval to Hub handlers.
Added purge nodes interval to Standalone handlers.
Introduced purge nodes interval configuration flag.
Added default and getter for purge nodes interval.
Integrated purge nodes interval into LocalDistributor logic.
Added snake-case type name generation for .NET.
Enhanced .NET templates with snake-case type serialization.
13 files
Updated tests to include purge nodes interval.
Enhanced tests for node draining with purge interval.
Added tests for node availability with purge interval.
Improved distributor tests with purge interval.
Enhanced session scheduling tests with purge interval.
Updated LocalDistributor tests for purge interval.
Added GraphQL handler tests for purge interval.
Enhanced JMX monitoring tests with purge interval.
Updated session creation tests with purge interval.
Improved router tests with purge interval.
Enhanced session cleanup tests with purge interval.
Updated session queue grid tests for purge interval.
Enhanced session queue grid timeout tests with purge interval.
1 files
Updated Bazel dependencies to newer versions.