-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add nullability to Logs API #14875
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RenderMichael !
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Adds nullable reference type annotations to logs API.
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
enhancement, error handling
Description
ArgumentNullException
checks for parameters that should not be null, improving error handling.LogEntry
.Changes walkthrough 📝
ILogs.cs
Enable nullability and add argument null check in ILogs
dotnet/src/webdriver/ILogs.cs
ArgumentNullException
forlogKind
parameter.LogEntry.cs
Enable nullability and improve LogEntry parsing
dotnet/src/webdriver/LogEntry.cs
LogLevel.cs
Enable nullability in LogLevel
dotnet/src/webdriver/LogLevel.cs
Logs.cs
Enable nullability and add argument null checks in Logs
dotnet/src/webdriver/Logs.cs
ArgumentNullException
fordriver
andlogKind
.