-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] feat: Add method to select options containing the provided text #14426
Merged
VietND96
merged 14 commits into
SeleniumHQ:trunk
from
syber911911:syber911911-feature-branch
Nov 8, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8ba67f7
[java] feat: Add method to select options containing the provided text
43b90d3
Merge branch 'trunk' into syber911911-feature-branch
syber911911 0cfe615
Merge branch 'trunk' into syber911911-feature-branch
syber911911 abfe72a
Merge branch 'trunk' into syber911911-feature-branch
syber911911 bcf441b
Merge branch 'trunk' into syber911911-feature-branch
syber911911 b06461c
Merge branch 'trunk' into syber911911-feature-branch
syber911911 b2f8254
[java]
604e5e3
Merge branch 'trunk' into syber911911-feature-branch
syber911911 13b170a
Merge branch 'trunk' into syber911911-feature-branch
syber911911 db511e2
Merge branch 'trunk' into syber911911-feature-branch
syber911911 2819469
Merge branch 'trunk' into syber911911-feature-branch
syber911911 0866faf
Merge branch 'trunk' into syber911911-feature-branch
VietND96 c1da1dd
Run format
VietND96 60157c5
Merge branch 'trunk' into syber911911-feature-branch
VietND96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VietND96 Hi.
I wonder why the opacity check is added. I saw some Select elements that have opacity set to 0, but they are interactable and functional. Is it to enforce some kind of best practice for web devs?
Because of this, we couldn't use the selectByContainsVisibleText().
It also seems inconsistent, as the selectByVisibleText() method does not have this check.
Maybe I'm not seeing the bigger picture, so I'm curious about this.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for adding the opacity check was to determine that a functionally operating element is a factor that exists but does not work when the developer intentionally sets the transparency to 0.0.