Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Recognise chrome-headless-shell as Chrome browser #13292

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[java] Recognise chrome-headless-shell as Chrome browser #13292

merged 1 commit into from
Dec 12, 2023

Conversation

valfirst
Copy link
Contributor

Description & Motivation and Context

Similar to #13271, but for Java client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @valfirst!

@diemol diemol merged commit 10c0c28 into SeleniumHQ:trunk Dec 12, 2023
35 of 41 checks passed
@valfirst valfirst deleted the recognise-chrome-headless-shell-as-chrome-browser branch December 12, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valfirst @diemol