Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Remove retrying on timeout exception #13224

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Related to #12975

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (240e17b) 57.53% compared to head (5172171) 57.95%.
Report is 8 commits behind head on trunk.

❗ Current head 5172171 differs from pull request most recent head 5593ab2. Consider uploading reports for the commit 5593ab2 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/safari/webdriver.py 50.00% 3 Missing ⚠️
py/selenium/webdriver/chromium/webdriver.py 83.33% 1 Missing and 1 partial ⚠️
py/selenium/webdriver/firefox/remote_connection.py 0.00% 1 Missing ⚠️
py/selenium/webdriver/firefox/webdriver.py 83.33% 1 Missing ⚠️
py/selenium/webdriver/ie/webdriver.py 87.50% 1 Missing ⚠️
py/selenium/webdriver/remote/webdriver.py 66.66% 1 Missing ⚠️
py/selenium/webdriver/safari/service.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13224      +/-   ##
==========================================
+ Coverage   57.53%   57.95%   +0.42%     
==========================================
  Files          86       88       +2     
  Lines        5310     5333      +23     
  Branches      221      224       +3     
==========================================
+ Hits         3055     3091      +36     
+ Misses       2034     2018      -16     
- Partials      221      224       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit b5a2e11 into SeleniumHQ:trunk Dec 4, 2023
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants