Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Support for automatic management of Firefox ESR #12946

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR enables the support for automatically managing Firefox ESR in Selenium Manager. For instance:

./selenium-manager --browser firefox --debug --browser-version esr
DEBUG   geckodriver not found in PATH
DEBUG   firefox detected at C:\Program Files\Mozilla Firefox\firefox.exe
DEBUG   Running command: wmic datafile where name='C:\\Program Files\\Mozilla Firefox\\firefox.exe' get Version /value
DEBUG   Output: "\r\r\n\r\r\nVersion=118.0.2.8682\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: firefox 118.0.2.8682
DEBUG   Discovered online firefox version (115) is different to the detected local firefox version (118)
DEBUG   Required browser: firefox 115.3.1esr
DEBUG   Downloading firefox 115.3.1esr from https://ftp.mozilla.org/pub/firefox/releases/115.3.1esr/win64/en-US/Firefox%20Setup%20115.3.1esr.exe
DEBUG   firefox 115.3.1esr is available at C:\Users\boni\.cache\selenium\firefox\win64\115.3.1esr\firefox.exe
DEBUG   Required driver: geckodriver 0.33.0
DEBUG   geckodriver 0.33.0 already in the cache
INFO    Driver path: C:\Users\boni\.cache\selenium\geckodriver\win64\0.33.0\geckodriver.exe
INFO    Browser path: C:\Users\boni\.cache\selenium\firefox\win64\115.3.1esr\firefox.exe

Motivation and Context

Requested in #12926.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (69b64f0) 56.51% compared to head (1cd7444) 56.51%.

❗ Current head 1cd7444 differs from pull request most recent head e9143fe. Consider uploading reports for the commit e9143fe to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12946   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonigarcia bonigarcia merged commit 8fee675 into trunk Oct 16, 2023
40 of 47 checks passed
@bonigarcia bonigarcia deleted the sm_firefox_esr branch October 16, 2023 12:48
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants