Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not switch and remove node in one iteration #11961

Merged
merged 2 commits into from
May 2, 2023

Conversation

joerg1985
Copy link
Member

Description

Do not switch and remove node in one iteration of the nodes in purgeDeadNodes.

Motivation and Context

see #11948

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (83b0b0d) 54.87% compared to head (ac0fc1d) 54.87%.

❗ Current head ac0fc1d differs from pull request most recent head 5187579. Consider uploading reports for the commit 5187579 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11961   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files          86       86           
  Lines        5735     5735           
  Branches      233      233           
=======================================
  Hits         3147     3147           
  Misses       2355     2355           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit 9ac368b into SeleniumHQ:trunk May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants