Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix test ignorance custom logic #11007

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[java] Fix test ignorance custom logic #11007

merged 1 commit into from
Sep 7, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR fix the logic for ignoring test based on the custom annotation @Ignore.

Motivation and Context

In the migration from JUnit 4 to JUnit 5, the existing test custom logic based on JUnit 4 was migrated to Jupiter. Nevertheless, the custom annotation @Ignore was not properly migrated. This PR fixes that issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia force-pushed the fix_ignore branch 2 times, most recently from 286ddba to e7e45d3 Compare September 5, 2022 14:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@titusfortner titusfortner merged commit 9850c95 into trunk Sep 7, 2022
@titusfortner titusfortner deleted the fix_ignore branch September 7, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants