Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Set protected as ClientConfig constructor instead of private #10985

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

KazuCocoa
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

I'd like to define a class that inherits ClientConfig in Appium java client that includes a few flags for Appium Java client. Current the constructor is private, so could we change this to protected?

Motivation and Context

We also considered defining an appium java client class that has ClientConfig as the member, but it could be confused for users to use both, ClientConfig and Appium java client config. So... for now, ideally, we'd like to define a subclass as AppiumClientConfig that has the ClientConfig plus a few Appium's client specific configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KazuCocoa
Copy link
Contributor Author

cc @titusfortner

@codecov-commenter
Copy link

Codecov Report

Merging #10985 (7fd8c52) into trunk (ff88671) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10985   +/-   ##
=======================================
  Coverage   52.24%   52.24%           
=======================================
  Files          84       84           
  Lines        5482     5482           
  Branches      272      272           
=======================================
  Hits         2864     2864           
  Misses       2346     2346           
  Partials      272      272           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @KazuCocoa!

@diemol diemol merged commit d1818d7 into SeleniumHQ:trunk Aug 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KazuCocoa KazuCocoa deleted the java-clientconfig branch August 30, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants