#10812 don't allow selecting a disabled option

[asolntsev]

fix for #10812

[codecov-commenter]

Codecov Report

Merging #10814 (f8ee2b5) into trunk (2fbfc62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10814   +/-   ##
=======================================
  Coverage   50.46%   50.46%           
=======================================
  Files          84       84           
  Lines        5477     5477           
  Branches      278      278           
=======================================
  Hits         2764     2764           
  Misses       2435     2435           
  Partials      278      278           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbfc62...f8ee2b5. Read the comment docs.

[pujagani]

Thank you for your contribution! @asolntsev The changes look good to me. Other language bindings will also need to add the same checks.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

[titusfortner]

Need to agree this is a problem (I don't think it is) before we solve it with this code.

I changed my mind this is a problem

[titusfortner]

I don't think we need to check if the select list is enabled. If it is disabled, the option will also be disabled. I'd prefer to optimize the number of commands made for a successful test rather than an unsuccessful test. What do you think?

[asolntsev]

I don't think we need to check if the select list is enabled. If it is disabled, the option will also be disabled. I'd prefer to optimize the number of commands made for a successful test rather than an unsuccessful test. What do you think?

Yes, I also like to make as few commands as possible.
But the correctness should be in first place, right?

If <select id="cars"> is disabled then user cannot select any options. Cannot even see them.
But method new Select($("#cars")).selectByValue("saab"); doesn't throw any exceptions. It leaves a false impression that the option has been selected.

[titusfortner]

A non-disabled option nested in a disabled select, will return false for isEnabled().
selectByValue() calls setSelected() which calls assertOptionIsEnabled() which will error.

That said, it's only one extra command when using this wrapper, and it does give a better error message, so maybe I'm being too picky.

@diemol what do you think of this implementation?

[diemol]

Thank you, @asolntsev!

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication