[🐛 Bug]: [rb]: Debug logger initialize gives "wrong number of arguments" #12005
Comments
|
@jorg-vr, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
|
Same issue here, didn't try if the suggested patch works, though. |
|
This is an issue with how Capybara is wrapping the Selenium Logger. I've submitted a PR for them, and they'll either accept it or get it sorted in another fashion. |
As a temporary workaround, we're fixing selenium-webdriver to v4.9.0 to avoid being hit by SeleniumHQ/selenium#12005.
As a temporary workaround, we're fixing selenium-webdriver to v4.9.0 to avoid being hit by SeleniumHQ/selenium#12005. [skip ci]
As a temporary workaround, we're fixing selenium-webdriver to v4.9.0 to avoid being hit by SeleniumHQ/selenium#12005. [skip ci]
|
Hello, and thanks again for your work on this issue! I just wanted to point out that this issue is still there, at least until a new version of Capybara is released and looking at teamcapybara/capybara#2666, releasing doesn't seem to be a priority at the moment. Maybe it's worth coordinating with the Capybara maintainers to understand how to move this forward. I'm available to help with that if needed, thanks! |
|
Some people I can't get to be bothered to update off of 5 year old versions. Some people can't stand not to always have the absolute latest versions. 😂 Capybara is a large open source project with a single unpaid maintainer. He'll get to a release when it is convenient for him to do so. The stakes are pretty low on this one. Just limit the version in your gemspec for now. |
|
I understand your point but sometimes it's not a choice. In our case, we are working on an open-source platform with many plugins (each of them is a gem with a standalone test suite) which are using the last version of That said, it's not the end of the world and we can definitely wait. I was just offering my help to speed up things if it was useful/needed. Thanks again for your work here. 👍 |
|
Managing a group of gems is a lot of hassle regardless. Not much to do here in the short term. Long term big picture, finding popular but under resourced open source projects and contributing to them enough to be entrusted with the ability to release them would make a huge difference to the ecosystem. |
|
Actually another thing here. What all is needed for a release? Is the CI passing? Any other bug fixes needed? Is it just a version bump? changelog? If you make a PR that does the drudge work and make it so that all @twalpole needs to do is merge it and run the release command that might be helpful by itself. |
|
I can definitely prepare the version bump, but since there are other things on the master branch since the last release (including dropping support for Ruby 2.7), I'm not sure what the next version is supposed to be. |
|
Please, let us know if we should move the conversation to the Capybara issue. For now, I'll keep it here as @twalpole has been tagged, and they can tell us the best thing to do. We were thinking of backporting the bug fix to the latest stable branch and submitting a PR there. However, we realized there's no Please, let us know if we can help in any other way, and thanks for your support on this. |
|
Fork the repo, create your own branch and merge whatever and make a PR with it. Worst case he decides to go a different way (essentially what happened with the PR I made). :) Just getting in the habit of proposing actual code instead of just raising issues makes a huge difference over time. |
|
Releasing takes work, and that takes time. Sometimes we value our family time over unpaid work and I would hope people in a well compensated industry would respect that. @titusfortner went out of his way to submit a PR, for which I went with a different solution and will do a new release when I have a few hours to spend on it. If you really need the latest today feel free to use the master branch of Capybara |
|
We have the PR ready to be submitted. But we need the corresponding |
|
Should v4.9.1 get pulled from rubygems? https://rubygems.org/gems/selenium-webdriver/versions/4.9.1 |
|
Why? To the extent that there is a bug, it is in Capybara, not Selenium. Capybara is wrapping the class with the wrong signature. Adding an optional keyword parameter to a method should not be considered a breaking change. One thing we might want to coordinate, @twalpole is that Selenium releases a nightly gem. If Capybara ran tests against that, we can double check things are working before we do a Selenium release in the future. And if anyone on this thread wants to help out with that, I'm sure it would be appreciated by everyone... |
|
okay understood, it felt like a breaking change because only upgrading the |
This reverts commit f468994. After the release of capybara 3.39.1 with a fix for the issue for the newest selenium-webdriver release, there's no longer the need to lock the later. See: - teamcapybara/capybara#2667 - teamcapybara/capybara#2666 - SeleniumHQ/selenium#12005
This reverts commit 9224baf. After the release of capybara 3.39.1 with a fix for the issue for the newest selenium-webdriver release, there's no longer the need to lock the later. See: - teamcapybara/capybara#2667 - teamcapybara/capybara#2666 - SeleniumHQ/selenium#12005
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
All our tests fail for the new selenium version 4.9.1 (See dodona-edu/dodona#4619)
I traced to root cause to changes made in 1cd84f7
Changing this line https://github.com/SeleniumHQ/selenium/blob/c6f7396f62d02932be0fc3b54846dca12bfa43a6/rb/lib/selenium/webdriver.rb#LL99C42-L99C42 from:
to
Fixes the issue
How can we reproduce the issue?
Relevant log output
Operating System
Linux mint
Selenium version
4.9.1
What are the browser(s) and version(s) where you see this issue?
Not using a browser
What are the browser driver(s) and version(s) where you see this issue?
ChromeDriver 111.0.5563.64
Are you using Selenium Grid?
No response
The text was updated successfully, but these errors were encountered: