add more checks

SeleniumHQ · Sep 20, 2024 · e725eeb · e725eeb
1 parent 94f0f5c
commit e725eeb
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
@@ -487,11 +487,20 @@ pub trait SeleniumManager {
                             discovered_major_browser_version,
                             major_browser_version,
                         ));
-                        self.set_fallback_driver_from_cache(false);
-                        return Err(anyhow!(format!(
-                            "Invalid version {} provided",
-                            major_browser_version
-                        )));
+                        if self
+                            .request_fixed_browser_version_from_online(
+                                major_browser_version.as_str(),
+                            )
+                            .is_err()
+                        {
+                            self.set_fallback_driver_from_cache(false);
+                            return Err(anyhow!(format!(
+                                "Invalid {} version provided: {}",
+                                self.get_browser_name(),
+                                major_browser_version
+                            )));
+                        }
+                        download_browser = true;
                     } else {
                         self.set_browser_version(discovered_version);
                     }

diff --git a/rust/tests/browser_tests.rs b/rust/tests/browser_tests.rs
@@ -169,3 +169,12 @@ fn invalid_browser_version_test() {
         .code(DATAERR)
         .failure();
 }
+
+#[test]
+fn valid_browser_version_pass_test() {
+    let mut cmd = get_selenium_manager();
+    cmd.args(["--browser", "chrome", "--browser-version", "127"])
+        .assert()
+        .code(0)
+        .success();
+}