Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image explainer #985

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix image explainer #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/graph/annotations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ You can configure aspects of Seldon Core via annotations in the SeldonDeployment
Otherwise any annotations starting with `seldon.io/engine-` will be interpreted as specifying environment variables for the engine container. These include:

* ```seldon.io/engine-java-opts``` : Java Opts for Service Orchestrator
* Locations : SeldonDeployment.spec.predictors.annotations
* Locations : SeldonDeployment.spec.annotations
* [Java Opts example](model_engine_java_opts.md)
* Translates to the environment variable JAVA_OPTS
* ```seldon.io/engine-seldon-log-requests``` : Whether to log raw requests from engine
Expand Down
4 changes: 2 additions & 2 deletions doc/source/graph/model_engine_java_opts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
},
"spec": {
"name": "test-deployment",
"annotations" : { "seldon.io/engine-java-opts" : "-Xmx1G" },
"predictors": [
{
"componentSpecs": [{
Expand All @@ -30,8 +31,7 @@
"type": "MODEL"
},
"name": "example",
"replicas": 1,
"annotations" : { "seldon.io/engine-java-opts" : "-Xmx1G" }
"replicas": 1
}
]
}
Expand Down
118 changes: 70 additions & 48 deletions notebooks/explainer_examples.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 8 additions & 3 deletions notebooks/resources/imagenet_explainer_grpc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ spec:
seldon.io/rest-read-timeout: "10000000"
seldon.io/grpc-read-timeout: "10000000"
seldon.io/grpc-max-message-size: "1000000000"
seldon.io/engine-java-opts: "-Xmx10G"
name: image
predictors:
- componentSpecs:
Expand Down Expand Up @@ -35,15 +36,19 @@ spec:
- name: model_output
type: STRING
value: predictions/Softmax:0
engineResources:
requests:
memory: 1Gi
svcOrchSpec:
resources:
requests:
memory: 10Gi
limits:
memory: 10Gi
env:
- name: SELDON_LOG_LEVEL
value: DEBUG
explainer:
type: anchor_images
modelUri: gs://seldon-models/tfserving/imagenet/explainer
config:
batch_size: "100"
name: default
replicas: 1
6 changes: 2 additions & 4 deletions notebooks/resources/model_engine_java_opts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
},
"spec": {
"name": "test-deployment",
"oauth_key": "oauth-key",
"oauth_secret": "oauth-secret",
"annotations" : { "seldon.io/engine-java-opts" : "-Xmx1G" },
"predictors": [
{
"componentSpecs": [{
Expand Down Expand Up @@ -42,8 +41,7 @@
"replicas": 1,
"labels": {
"version" : "v1"
},
"annotations" : { "seldon.io/engine-java-opts" : "-Xmx1G" }
}
}
]
}
Expand Down