Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd changes for creds secret #782

Merged
merged 1 commit into from
Aug 12, 2019
Merged

crd changes for creds secret #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm-charts/seldon-core-operator/templates/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1952,6 +1952,7 @@ spec:
type:
enum: [REST, GRPC]
type: string
envSecretRefName: {type: string}
modelUri: {type: string}
serviceAccountName: {type: string}
type: {type: string}
Expand All @@ -1974,6 +1975,7 @@ spec:
type:
enum: [REST, GRPC]
type: string
envSecretRefName: {type: string}
implementation:
enum: [UNKNOWN_IMPLEMENTATION, SIMPLE_MODEL, SIMPLE_ROUTER,
RANDOM_ABTEST, AVERAGE_COMBINER, SKLEARN_SERVER,
Expand Down
4 changes: 3 additions & 1 deletion proto/seldon_deployment.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ message Explainer {
optional string type = 1; // Type of explainer
optional string modelUri = 2; // Bucket or PVC location of explainer model
optional string serviceAccountName = 3; // Service account for pulling from bucket
optional k8s.io.api.core.v1.Container containerSpec = 4; // Custom spec for explainer
optional string envSecretRefName = 4; // Secret for pulling from bucket
optional k8s.io.api.core.v1.Container containerSpec = 5; // Custom spec for explainer
}

message PredictorSpec {
Expand Down Expand Up @@ -127,6 +128,7 @@ message PredictiveUnit {
repeated Parameter parameters = 7; // Customer parameter to pass to the unit.
optional string modelUri = 8; // Location of saved model
optional string serviceAccountName = 9; // Service account for pulling model bucket
optional string envSecretRefName = 10; // Secret for pulling from bucket
}

message Endpoint {
Expand Down
6 changes: 6 additions & 0 deletions util/custom-resource-definitions/crd.tpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
"serviceAccountName": {
"type": "string"
},
"envSecretRefName": {
"type": "string"
},
"implementation": {
"enum": [
"UNKNOWN_IMPLEMENTATION",
Expand Down Expand Up @@ -291,6 +294,9 @@
"serviceAccountName": {
"type": "string"
},
"envSecretRefName": {
"type": "string"
},
"type": {
"type": "string"
},
Expand Down