add engine resources to proto and modify cluster manager #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximophone
reviewed
Jan 25, 2018
| if (predictorDef.hasEngineResources()) | ||
| cBuilder.setResources(predictorDef.getEngineResources()); | ||
| else // set default resource requests for cpu | ||
| cBuilder.setResources(V1.ResourceRequirements.newBuilder().putRequests("cpu", Quantity.newBuilder().setString("0.1").build())); |
There was a problem hiding this comment.
the 0.1 default should be a variable in a config file somewhere else
|
Tested on minikube, will merge |
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* add dataplane protos for reverse grpc proxy * GRPC reverse proxy * add an inital test * use seldon-model as key * wire up reverse grpc proxy * add a test case for concurrent infer * remove unused code * tidy up test * fix test * add test for model error * implement metadata endpoint for grpc * Add test for metadata grpc * fix rest reverse proxy to handle metadata endpoint * fix lint * fixes for protos * error if state is not set * adjust makefile for triton * fix test * implement ModelReady in reverse proxy * add maxConnection * add retry * refactor client service starting * fix typo * deal with Ready thread-safety * check slice has elements * add a note * change Ready to return bool * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72