Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow User Defined Exceptions #651

Merged
merged 7 commits into from
Jun 26, 2019
Merged

Allow User Defined Exceptions #651

merged 7 commits into from
Jun 26, 2019

Conversation

klalit
Copy link
Contributor

@klalit klalit commented Jun 25, 2019

Fixes #625

@klalit
Copy link
Contributor Author

klalit commented Jun 26, 2019

@cliveseldon I checked the build logs, it failed because of access denied to maven url

Access denied to: https://repo.maven.apache.org/maven2/kr/motd/maven/os-maven-plugin/1.4.1.Final/os-maven-plugin-1.4.1.Final.jar , ReasonPhrase:Forbidden. @

Please suggest

@ukclivecox ukclivecox changed the title Implementation of https://github.com/SeldonIO/seldon-core/issues/625 Allow User Defined Exceptions Jun 26, 2019
@gsunner
Copy link
Contributor

gsunner commented Jun 26, 2019

restarted the failed travis build, passed now

@klalit
Copy link
Contributor Author

klalit commented Jun 26, 2019

@cliveseldon @gsunner I've completed the implementation. Please merge it.

@seldondev seldondev added size/L and removed size/M labels Jun 26, 2019
@ukclivecox ukclivecox merged commit 2dbf3be into SeldonIO:master Jun 26, 2019
agrski pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Exceptions raised in predict function of a wrapper class needs to be handled via flask exception handler
4 participants