Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU Tensorflow Example #623

Closed
wants to merge 7 commits into from
Closed

GPU Tensorflow Example #623

wants to merge 7 commits into from

Conversation

JoelH96
Copy link
Contributor

@JoelH96 JoelH96 commented Jun 6, 2019

Tensorflow GPU Deep MNIST example. Solutions for Issues #590 and #602.

@JoelH96 JoelH96 requested a review from axsaucedo June 6, 2019 15:21
ukclivecox
ukclivecox suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we download the MNIST training data. Need tocheck copyright on us keeping it in the repo as not sure that is ok.

ukclivecox
ukclivecox suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include trained model binary files in repo?

@JoelH96
Copy link
Contributor Author

JoelH96 commented Jun 6, 2019

I have removed the MNIST training data and the binary files from the example

@JoelH96
Copy link
Contributor Author

JoelH96 commented Jun 6, 2019

Closing the PR for now, as going to do the testing on GKE first.

@JoelH96 JoelH96 closed this Jun 6, 2019
agrski pushed a commit that referenced this pull request Dec 2, 2022
@RafalSkolasinski
fix type of terminationGracePeriodSeconds in helm charts (#623)
375ed15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox ukclivecox requested changes

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelH96 @ukclivecox @seldondev