Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k6): Add k6 controlplane with dataplane runs #5977

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Oct 14, 2024

This PR introduces model replicas changes as inference go through to understand the behaviour of the system under such scenarios.

The scenarios that are enabled are:

  • infer_constant_rate
  • infer_constant_vu

To trigger model replica changes, set ENABLE_MODEL_REPLICA_CHANGE. The number of replicas is chosen uniformly between 1 and MAX_MODEL_REPLICAS.

We also support sleeping after each model replica change by setting SLEEP_BETWEEN_REPLICA_CHANGE.

@sakoush sakoush requested a review from lc525 as a code owner October 14, 2024 16:15
@sakoush sakoush added the v2 label Oct 14, 2024
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; just a small comment on extracting the common functionality if you also think it's reusable.

@sakoush sakoush merged commit 7c88403 into SeldonIO:v2 Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants