fix: operator build fix for macOS arm chips #5952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
reviewed
Oct 3, 2024
| @@ -48,11 +48,11 @@ help: ## Display this help. | |||
| .PHONY: manifests | |||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | |||
| $(CONTROLLER_GEN) rbac:roleName=v2-manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases | |||
| sed -i '/namespace: seldon-mesh/d' config/rbac/role.yaml # remove namespace added by controller-gen | |||
| sed -i -e '/namespace: seldon-mesh/d' config/rbac/role.yaml # remove namespace added by controller-gen | |||
There was a problem hiding this comment.
sadly, -i and -e mean different things on BSD sed (closest to the one on MacOS) and on GNU (linux) sed.
See here:
So we would not be able to accept this PR as it prevents the script from running on all other dev machines.
There was a problem hiding this comment.
The command would still run on linux, but would no longer do the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the operator build on mac arm based chip
This was also reported here #5917
I noticed that sed command is working differently on linux and macOS adding
-eflag resolves the issue.