-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): Adjust controller -> scheduler state recreation upon scheduler disconnect. #5944
Merged
sakoush
merged 40 commits into
SeldonIO:v2
from
sakoush:INFRA-1198/fix_controller_client_conn
Oct 4, 2024
Merged
fix(controller): Adjust controller -> scheduler state recreation upon scheduler disconnect. #5944
sakoush
merged 40 commits into
SeldonIO:v2
from
sakoush:INFRA-1198/fix_controller_client_conn
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
changed the title
fix(controller): Adjust controller -> scheduler state recreation upton scheduler disconnect.
fix(controller): Adjust controller -> scheduler state recreation upon scheduler disconnect.
Sep 30, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
reviewed
Oct 4, 2024
lc525
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this improves things considerably from our current state, and hope all the testing doesn't show any issues.
I do have a question regarding the ServerBasedSynchronizer for a particular edge case, and a couple of other nits, but otherwise all looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the way we are resetting scheduler / controller state upon connection drops. Previously the state reconstruction was tightly couples with stream handling and this had a few issues:
The solution is to separate out the logic and trigger state reconstruction on a separate stream. These operations are idempotent and therefore it is fine to send them anyway.
The main logic is now in
handleStateOnReconnect
We are also introducing a new grpc stream between scheduler<->operator that would trigger this logic
ControlPlaneSubscription
. Essentially when the scheduler gets a subscribe request on this stream it replies to controller to initiate the state reconstruction logic, this process is done on each connection reset.Which issue(s) this PR fixes:
Fixes #
INFRA-1198 (internal).
Special notes for your reviewer:
SubscribeModelEvents
.LoadModel
andUnloadModel
to not to block on scheduling. This is safe as we rely on the state transition events to report status and from the cli perspective it is not required to wait for scheduling.