Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add experiments pipeline tests for envoy processor #5810

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Jul 29, 2024

This PR increases tests coverage to understand the behaviour of envoy when different resources change state.

@sakoush sakoush requested a review from lc525 as a code owner July 29, 2024 17:18
@sakoush sakoush added the v2 label Jul 29, 2024
@@ -356,6 +358,21 @@ func createTestModel(modelName string,
return f
}

func remoteTestModel(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "removeTestModel" ?

Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; with one question. Sorry for the delay in reviewing this

@sakoush sakoush merged commit 349570a into SeldonIO:v2 Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants