Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate use of Go Seldon Controller #559

Merged
merged 55 commits into from
May 18, 2019
Merged

Integrate use of Go Seldon Controller #559

merged 55 commits into from
May 18, 2019

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented May 10, 2019 •
edited
Loading

Main changes

  • New seldon-core-controller helm chart that installs CRD and the Go Controller.
    • This is cluster-wide. There is no namespace local controller anymore.
  • Installing ingress is now up to user. They can install the official Ambassador or Seldon OAuth Gateway
  • New Helm chart for Seldon OAuth gateway seldon-core-oauth-gateway

Updates

  • Helm charts updated
  • All notebooks and docs changed

@ukclivecox
add missing additionProperties to openAPI specs for CRDS
12e62cb
@ukclivecox
Merge branch 'master' into go_operator_rewrite
1f00d8b
@ukclivecox
remove parts of the openAPI validation that have properties that are …
cb4922b 
…called 'items' due to go openapi bug in k8s
@ukclivecox
Update notebooks
a714564
@ukclivecox
remove v1alpha3 and revert to v1alpha2
a4ec063
@ukclivecox
fix for svc-orchestrator name - add hash to name
d854487
@ukclivecox
Merge branch 'master' into crd_v1alpha3_revert
60373cb
@ukclivecox
rebase
054bbbb
@ukclivecox
update openvino example
88861b5
@ukclivecox
update openvino_imagenet demo
eae87ea
@ukclivecox
onnx resnet example update
6c5f694
@ukclivecox
Update R MNIST demo
04a4c8b
@ukclivecox
Update Sagemaker example
3ecefcf
@ukclivecox
update nitebook docs
840e44b
@ukclivecox
update R examples
f1ae75a
@ukclivecox
update sklearn iris example!
76163bd
@ukclivecox
update skmnist example
686fd04
@ukclivecox
update deep mnist example
29601bc
@ukclivecox
update istio canary example
0579d41
@ukclivecox
add oauth gateway helm chart
b66dacc
@ukclivecox
updates for gateway
bc6934f
@ukclivecox
testing uodates
275b2a2
@ukclivecox
Merge branch 'master' into go_operator_rewrite
b3f5790
@ukclivecox
updates for testing
7096fd8
@ukclivecox
fix redis name in apife chart
d5629cd
@ukclivecox
add seldon-core controller helm chart
452366e
@ukclivecox
add redis to gateway helm chart
1901aa0
@ukclivecox
Update tests
c70b8dc
@ukclivecox
Update docs
1c792d4
@ukclivecox
update helm charts
4bbda25
@ukclivecox ukclivecox requested a review from gsunner May 10, 2019 11:56
@ukclivecox ukclivecox self-assigned this May 10, 2019
gsunner
gsunner suggested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@gsunner gsunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the name be changed to "seldon-operator" as its a controller dealing with a specific CRD

From CoreOS docs on subject: "An Operator is an application-specific controller ..."
Discussion on github: kubeflow/training-operator#300

@ryandawsonuk
Copy link
Contributor

After this is done we could look again at the priority of #443 and #114

This was referenced May 13, 2019
Closed
Closed
@ukclivecox ukclivecox requested a review from gsunner May 16, 2019 09:17
ryandawsonuk
ryandawsonuk approved these changes May 16, 2019
View reviewed changes
doc/source/graph/helm_charts.md Outdated Show resolved Hide resolved
helm-charts/seldon-core-controller/values.yaml Outdated Show resolved Hide resolved
helm-charts/seldon-core-controller/values.yaml Outdated Show resolved Hide resolved
helm-charts/seldon-core-controller/values.yaml Outdated Show resolved Hide resolved
components/routers/case_study/credit_card_default.ipynb Outdated Show resolved Hide resolved
helm-charts/Makefile Outdated Show resolved Hide resolved
start-seldon-core-private-repo Outdated Show resolved Hide resolved
testing/scripts/test_helm_charts_clusterwide.py Outdated Show resolved Hide resolved
@ukclivecox ukclivecox merged commit 240d559 into SeldonIO:master May 18, 2019
@ukclivecox ukclivecox deleted the go_operator_rewrite branch February 14, 2020 11:39
agrski pushed a commit that referenced this pull request Dec 2, 2022
@sakoush
Quickfix/fixstop notready (#559)
7e88d4f 
* fix drainer

* stats analyser fix

* agent debug fix

* grpc proxy fix

* http reverse proxy fix

* prom server fix

* otel fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsunner gsunner gsunner approved these changes

@ryandawsonuk ryandawsonuk ryandawsonuk approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukclivecox @ryandawsonuk @gsunner @seldondev